[DataGrid] Add fluid columns width support #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
…:DanailH/material-ui-x into feature/DataGrid-347-columns-fluid-width
…toHaveInlineStyle
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
…:DanailH/material-ui-x into feature/DataGrid-347-columns-fluid-width
|
When it's time to merge, I'll write a custom commit message before merging for the squished commits to avoid the noise. |
From my perspective, the best approach is to empty the description field. In this case, I would also rename the commit message to something more descriptive. [reopen] isn't a valid label we have.
|
oliviertassinari
changed the title
oliviertassinari
added
component: data grid
packages/grid/_modules_/grid/components/styled-wrappers/GridRootStyles.ts
Outdated
Show resolved
Hide resolved
…otStyles.ts Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
…:DanailH/material-ui-x into feature/DataGrid-347-columns-fluid-width
oliviertassinari
approved these changes
Nov 10, 2020
|
@dtassone can you check the PR when you have time, please 😉 |
dtassone
approved these changes
Nov 11, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm reopening the PR #480 for the fluid columns. The tests are passing locally. Everything is the same as before with one exception -> the
viewportWidthis now being selected fromgridState.viewportSizes.width, using the refactor that @dtassone did.Closes #347