[DataGrid] Fix focused cell if column is spanned and new editing API is used #5962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4theushw
added
the
component: data grid
|
These are the results for the performance tests:
|
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
cherniavskii
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing the tests for #5911 I noticed that, when using the new editing API, if a cell is committed with Enter and the cell below is spanned, the focus is not moved to the correct cell.
Before: https://codesandbox.io/s/keen-christian-ipv4v4?file=/demo.tsx
After: https://codesandbox.io/s/serverless-microservice-8hbnoe?file=/demo.tsx
How to reproduce:
Expected behavior
It should move focus to the price column in the last row but it doesn't. In the legacy API it works as expected.