[core] Replace storybook knobs for args #601
Conversation
|
|
||
| const env = process.env.NODE_ENV || 'development'; | ||
| /* eslint-disable */ | ||
| const __DEV__ = env === 'development'; | ||
| const __PROD__ = env === 'production'; | ||
| const isDevelopment = env === 'development'; |
There was a problem hiding this comment.
DEV is already defined somewhere globally, typescript complains
| @@ -1,3 +1,4 @@ | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
To find out why and remove
| checkboxSelection: true, | ||
| disableSelectionOnClick: false, | ||
| disableMultipleColumnsSorting: false, | ||
| sortingOrder: ['asc', 'desc', 'null' as SortDirection], |
There was a problem hiding this comment.
null is not displayed as a string, small trick here...
|
Thanks Tooppaaa it looks great. |
|
@dtassone What's the next step on this pull request? |
| </div> | ||
| ); | ||
| } | ||
| export const Loading = Template.bind({}); |
There was a problem hiding this comment.
Could we wrap that to make it more understandable on what we do here?
Maybe
const getStoryTemplate = ()=> Template.bind({});
There was a problem hiding this comment.
The following is a storybook pattern:
export const Foo = Bar.bind({});
Foo.args = { ... }
We recommend everybody use this pattern if they are using Args stories, since we have some tooling in mind that will look for this pattern in static analysis...
It's actually ready, beside conflicts and my little comment... I originally thought that there was more work to do on controls but it seems ready |
|
I'll handle everything tonight / this weekend ! |
|
@dtassone everything should be up do date and with the same functionality as before. |
oliviertassinari
changed the title
oliviertassinari
changed the title
Storybook knobs are being shut down in favor of args.
https://storybook.js.org/docs/react/writing-stories/args
This is using react docgen behind the scene to generate the right controls and actions.
I tried to only change what was necessary to remove knobs without loosing any functionality in place.
While there's still work to do on this like
cleanup remaining defined actions
arrange stories to capitalize on args
Regarding performances, enabling reactDocgen only adds 0.3 secs