Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Fix x-date-pickers-pro theme augmentation #6096

Merged
merged 16 commits into from
Sep 14, 2022

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Sep 9, 2022

Fixes #4673
Fixes #4942

  • Fix pro package components theme augmentation (style and prop overrides).
  • Apply static pickers className to root element (for 4942)
  • Add some missing base package components to themeAugmentation

@LukasTy LukasTy added typescript plan: Pro Impact at least one Pro user component: pickers This is the name of the generic UI component, not the React module! customization: css Design CSS customizability labels Sep 9, 2022
@mui-bot
Copy link

mui-bot commented Sep 9, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 545.5 1,077 600.8 803.86 209.665
Sort 100k rows ms 720.8 1,315 1,315 1,048.66 198.834
Select 100k rows ms 276.1 381.2 315.4 317.4 38.981
Deselect 100k rows ms 177.3 391 202.7 237.28 78.81

Generated by 🚫 dangerJS against 9dd5c56

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 9, 2022
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 9, 2022
@DanailH
Copy link
Member

DanailH commented Sep 12, 2022

I remember some discussion about having this one released under v5. Is that still the case?

@LukasTy
Copy link
Member Author

LukasTy commented Sep 12, 2022

@DanailH Yes, I'd like for this and following PR for x-date-pickers to be in v5 just to make v5 release more open to styling extension. 🤔

Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 🎉

@LukasTy LukasTy merged commit 98b6c03 into mui:master Sep 14, 2022
@LukasTy LukasTy deleted the fix-pickers-theme-augmentation branch September 14, 2022 07:25
LukasTy added a commit to LukasTy/mui-x that referenced this pull request Sep 15, 2022
* Add static pickers to augmentation types

* Fix to correctly pass down `className` to static picker wrapper

* Correctly apply `DateRangePickerDay` style overrides

* Use classes and className in range picker components
LukasTy added a commit that referenced this pull request Sep 15, 2022
[pickers] Fix `x-date-pickers-pro` theme augmentation (#6096)

* Add static pickers to augmentation types

* Fix to correctly pass down `className` to static picker wrapper

* Correctly apply `DateRangePickerDay` style overrides

* Use classes and className in range picker components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! customization: css Design CSS customizability plan: Pro Impact at least one Pro user typescript
Projects
None yet
4 participants