Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Enable codesandbox preview in PRs #613

Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 21, 2020

See mui/material-ui#22616 for the why.

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Nov 21, 2020
@oliviertassinari oliviertassinari marked this pull request as draft November 28, 2020 12:18
@oliviertassinari oliviertassinari force-pushed the enable-docs-codesandbox-preview branch from e9f6ded to c10ebd6 Compare December 4, 2020 15:29
@oliviertassinari oliviertassinari force-pushed the enable-docs-codesandbox-preview branch from c10ebd6 to dae3284 Compare December 4, 2020 15:47
@oliviertassinari oliviertassinari marked this pull request as ready for review December 4, 2020 15:47
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Dec 4, 2020

Ok. This time, it works. These two demos were open from https://deploy-preview-613--material-ui-x.netlify.app/components/data-grid/.
Capture d’écran 2020-12-04 à 16 49 32

They use the code of my branch, no the stable release of npm. I wish I had this a dozen times these last few months during reviews :).

@oliviertassinari oliviertassinari merged commit 538ef62 into mui:master Dec 4, 2020
@oliviertassinari oliviertassinari deleted the enable-docs-codesandbox-preview branch December 4, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants