-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[I10n] Add Finnish (fi-FI) locale to pickers #6219
[I10n] Add Finnish (fi-FI) locale to pickers #6219
Conversation
These are the results for the performance tests:
|
For now the placeholder is not customizable with the locale. You can manually override the placeholder passed to your input like so: <DatePicker
label="Basic example"
value={value}
onChange={(newValue) => {
setValue(newValue);
}}
renderInput={(params) =>
<TextField
{...params}
inputProps={{ ...params.inputProps, placeholder: 'pp.kk.vvvv' }}
/>
}
/> Note that it won't react to any change in the format and you have to manually take care of it. |
Right, I assumed so since I wasn't able to find anything related to it. Sounds like a good addition as other translations are handled by mui that the placeholder would be handled also👍🏻 |
Would you be able to review this @flaviendelangle or how should I proceed with the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution !
It currently targets the next
branch which is for the v6 alpha releases.
I will port this PR to the master
branch to have it available on the v5 release as well.
I noticed that the DataGrid had support for Finnish locale but datepicker was lacking it
Translations were formed by myself a native Finnish speaker with the assist of Microsoft language portal and Google Translate
Couldn't find where to change the default placeholder for the datepicker. It should bepp.kk.vvvv
in Finnish instead ofdd.mm.yyyy