-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Pass generics to the components in the theme augmentation #6269
[DataGrid] Pass generics to the components in the theme augmentation #6269
Conversation
These are the results for the performance tests:
|
Looks like we are missing Update: Fixed by #6270 |
Why did you close? |
Github closed it automatically, because in #6270 I referenced a comment from this PR :) |
Hi guys, we're currently paying for a group of devs to use the DataGrid component and we are attempting to use typescript + the theme in the global style overrides callback. I was wondering what the status/priority of this issue is? Thanks! We would like to get access to the custom type definitions present on our theme object with this usage:
Here is a sandbox to illustrate the issue. |
Hey @paulleonartcalvo |
Fixes #6268
Same as #5199, but for the grid
Before: https://codesandbox.io/s/muidatagrid-theme-override-forked-1czck5?file=/src/theme.ts
After: https://codesandbox.io/s/muidatagrid-theme-override-fgfz36?file=/src/theme.ts
master
branch [DataGrid] Pass generics to the components in the theme augmentation #6406