[CalendarPicker] Prevent getting focus when autoFocus=false

[alexfauquette]

In DatePicker doc page the focus is caught by the year picker.

This PR should fix this bug

[mui-bot]

These are the results for the performance tests:

Test case	Unit	Min	Max	Median	Mean	σ
Filter 100k rows	ms	561	970.6	704.6	742.22	167.698
Sort 100k rows	ms	609.7	1,261.2	609.7	945.06	219.471
Select 100k rows	ms	215.6	352.4	280.2	274.38	48.096
Deselect 100k rows	ms	156.6	345.5	182.8	209.68	68.638

Generated by 🚫 dangerJS against 20ce901

[flaviendelangle]

Nice fix

I did not test it, but what is preventing us from doing this update in the render like we do in usePickerState ?
React tends to recommend that approach over an effect: https://fr.reactjs.org/docs/hooks-faq.html#how-do-i-implement-getderivedstatefromprops

[alexfauquette]

@flaviendelangle I don't get to which part of usePickerState you are referring to

[flaviendelangle]

@alexfauquette

mui-x/packages/x-date-pickers/src/internals/hooks/usePickerState.ts

Lines 257 to 260 in 85dadfa

	// Set the draft and committed date to equal the new prop value.
	if (!valueManager.areValuesEqual(utils, dateState.committed, value)) {
	setDate({ action: 'setCommitted', value, skipOnChangeCall: true });
	}

[alexfauquette]

It's not possible because it updates multiple components, and apparently, you should not update your parents during the render phase. Only inside effect.

I assume the proposed technic to derive state from props only works if the state is limited to the current component

[flaviendelangle]

It's not possible because it updates multiple components, and apparently, you should not update your parents during the render phase. Only inside effect.

Make sense 👍

[flaviendelangle]

OK to merge it as is 👍