Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Fix server-side pagination #639

Merged
merged 7 commits into from
Nov 27, 2020
Merged

[DataGrid] Fix server-side pagination #639

merged 7 commits into from
Nov 27, 2020

Conversation

dtassone
Copy link
Member

@dtassone dtassone commented Nov 25, 2020

Fix #568

@dtassone dtassone changed the title fix #568 and other small issues [DataGrid] fix #568 and other small issues Nov 25, 2020
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix #568 and other small issues

Please one pull request at the time, it doesn't work https://deploy-preview-639--material-ui-x.netlify.app/components/data-grid/pagination/#server-side-pagination

@oliviertassinari oliviertassinari changed the title [DataGrid] fix #568 and other small issues [DataGrid] Fix server-side pagination Nov 25, 2020
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! labels Nov 25, 2020
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pagination is not working: https://deploy-preview-639--material-ui-x.netlify.app/components/data-grid/pagination/#server-side-pagination. The CI should be red, a test case should be falling in the current state.

@dtassone
Copy link
Member Author

Pagination is not working: https://deploy-preview-639--material-ui-x.netlify.app/components/data-grid/pagination/#server-side-pagination. The CI should be red, a test case should be falling in the current state.

I tried the docs locally, and it works. I also tried with the filtering, columns, and all the new options disabled, and it works.
The error on the server is
image

Any idea?
🤔

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 26, 2020

I tried the docs locally, and it works. I also tried with the filtering, columns, and all the new options disabled, and it works.

Is it feature flag related?

The error on the server is

This is a client side error, and unrelated. Probably your ad blocker.

@dtassone
Copy link
Member Author

I tried the docs locally, and it works. I also tried with the filtering, columns, and all the new options disabled, and it works.

Is it feature flag related?

The error on the server is
Yeah I'm wondering... Let me push an update to test that

This is a client side error, and unrelated.

I mean, it's the error on the server, I didn't mean it occured on the backend

@oliviertassinari
Copy link
Member

I mean, it's the error on the server, I didn't mean it occured on the backend

I don't follow, we probably have a different vocabulary, what's the backend, what's the server? I was assuming this terminology: server = node.js, backend = we don't have one.

@dtassone
Copy link
Member Author

I mean, it's the error on the server, I didn't mean it occured on the backend

I don't follow, we probably have a different vocabulary, what's the backend, what's the server? I was assuming this terminology: server = node.js, backend = we don't have one.

For me, server can be the CI server, vs local where it's my own machine.
Backend as opposed to frontend, the code that runs on the server machine, so nodejs...

@dtassone
Copy link
Member Author

I managed to reproduce the error locally. It's due to the production code, so probably an issue with the minifier... 🤔

@DanailH
Copy link
Member

DanailH commented Nov 27, 2020

Just a general question, a lot of the changes from this PR are also in this one #642. I guess this PR should be the first one merged right?

@dtassone
Copy link
Member Author

Just a general question, a lot of the changes from this PR are also in this one #642. I guess this PR should be the first one merged right?

Yes

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 27, 2020

The documentation pages are broken after the changes, however, it doesn't seem directly related, so happy to move forward. We need to fix the pages before we can cut a new release.

@dtassone dtassone merged commit f017198 into mui:master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataGrid] server side pagination not working
3 participants