[pickers] New MobileDateRangePicker, DesktopDateRangePicker, DateRangePicker and StaticDateRangePicker based on MultiInputDateRangeField
#6888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ePicker and StaticDateRangePicker based on MultiInputDateRangeField
flaviendelangle
added
the
component: pickers
These are the results for the performance tests:
|
flaviendelangle
commented
Nov 17, 2022
| * We don't pass all the props down to `DateRangeCalendar`, | ||
| * because otherwise some unwanted props would be passed to the HTML element. | ||
| */ | ||
| export const renderDateRangeView = <TDate extends unknown>({ |
There was a problem hiding this comment.
If you have a better solution here, I'm interested
At least it is centralized 😬
There was a problem hiding this comment.
Not sure their is a better way than listing the props that can be passed. The other options would be to stop them when rendering the HTML element which does not seems better
| controlled: inValue, | ||
| default: defaultValue ?? valueManager.emptyValue, | ||
| name: 'usePickerState2', | ||
| state: 'value', | ||
| }); | ||
|
|
||
| const value = React.useMemo( |
There was a problem hiding this comment.
I forgot to apply this change on the new pickers when doing #6170 and it causes a bug on the range picker when the date is not valid
| import { SlotComponentProps } from '@mui/base/utils'; | ||
| import TextField, { TextFieldProps } from '@mui/material/TextField'; | ||
| import type { UseFieldInternalProps } from '../hooks/useField'; | ||
|
|
||
| export interface BaseFieldProps<TValue, TError> | ||
| extends Omit<UseFieldInternalProps<TValue, TError>, 'format'> { | ||
| className?: string; |
There was a problem hiding this comment.
Not related to this PR, I forgot to extract it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API changes
MobileDateRangePickerRemove mask related props
acceptRegexdisableMaskedInputignoreInvalidInputsmaskrifmFormatterUse component slots everywhere
InputProps=>componentsProps.input.InputPropsrenderInput=>components.Field/components.Input/components.FieldRoot/components.FieldSeparatordepending on the use caseRemove props already not used in v5
childrenInputAdornmentPropsOpenPickerButtonPropsOpenPickerIconinputReflabelonViewChangegetOpenDialogAriaTextshouldDisableMonthshouldDisableYearProp renaming
inputFormat=>formatDesktopDateRangePickerRemove mask related props
acceptRegexdisableMaskedInputignoreInvalidInputsmaskrifmFormatterUse component slots everywhere
InputProps=>componentsProps.input.InputPropsrenderInput=>components.Field/components.Input/components.FieldRoot/components.FieldSeparatordepending on the use caseRemove props already not used in v5
childrenInputAdornmentPropsOpenPickerButtonPropsOpenPickerIconinputReflabelonViewChangegetOpenDialogAriaTextshouldDisableMonthshouldDisableYearProp renaming
inputFormat=>formatDateRangePickerRemove mask related props
acceptRegexdisableMaskedInputignoreInvalidInputsmaskrifmFormatterUse component slots everywhere
InputProps=>componentsProps.input.InputPropsrenderInput=>components.Field/components.Input/components.FieldRoot/components.FieldSeparatordepending on the use caseRemove props already not used in v5
childrenInputAdornmentPropsOpenPickerButtonPropsOpenPickerIconinputReflabelonViewChangegetOpenDialogAriaTextshouldDisableMonthshouldDisableYearProp renaming
inputFormat=>formatStaticDateRangePickerRemove mask related props
acceptRegexdisableMaskedInputignoreInvalidInputsmaskrifmFormatterRemove keyboard editing related props (no more keyboard mode on the mobile toolbar)
renderInputInputPropsinputFormatRemove props already not used in v5
InputAdornmentPropsOpenPickerButtonPropsOpenPickerIconinputReflabelonViewChangegetOpenDialogAriaTextshouldDisableMonthshouldDisableYearcloseOnSelectdisableOpenPicker