Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Update minimum supported version of Node.js to 14.0.0 #6966

Merged
merged 2 commits into from
Nov 23, 2022
Merged

[core] Update minimum supported version of Node.js to 14.0.0 #6966

merged 2 commits into from
Nov 23, 2022

Conversation

cherniavskii
Copy link
Member

Closes #5605

We've upgraded Node.js version used in CircleCI, Netlify and Codesandbox CI earlier in #4999

@cherniavskii cherniavskii added core Infrastructure work going on behind the scenes breaking change v6.x labels Nov 22, 2022
@mui-bot
Copy link

mui-bot commented Nov 22, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-6966--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 660.3 992.2 780.9 807.42 130.453
Sort 100k rows ms 612 1,102.5 859.4 864.2 155.536
Select 100k rows ms 180 463.4 220.6 276.06 101.305
Deselect 100k rows ms 145.4 311.3 173.4 209.36 62.76

Generated by 🚫 dangerJS against f8a1201

@cherniavskii cherniavskii changed the title [core] Update minimum supported version of Node.js [core] Update minimum supported version of Node.js to 14.0.0 Nov 22, 2022
LukasTy
LukasTy approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🙌
It's just gonna be a bit strange having @mui/material still being fine with v12 for some time. 🙈

@cherniavskii cherniavskii merged commit 6ad6c4b into mui:next Nov 23, 2022
@cherniavskii cherniavskii deleted the bump-node-version branch November 23, 2022 11:04
@oliviertassinari oliviertassinari mentioned this pull request Jul 15, 2024
Closed
@DiegoAndai DiegoAndai mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

@m4theushw m4theushw Awaiting requested review from m4theushw

Assignees
No one assigned
Labels
breaking change core Infrastructure work going on behind the scenes v6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[core] Upgrade the min node.js version supported to v14
3 participants
@cherniavskii @mui-bot @LukasTy