[DataGrid] Fix components casing, rm context, refact GridComponent #707
Conversation
| }), | ||
| [handleMouseDown], | ||
| ); | ||
| useApiMethod<ColumnResizeApi>(apiRef, { startResizeOnMouseDown: handleMouseDown }, 'columnResizeApi') |
There was a problem hiding this comment.
Shouldn't we do the opposite, have a generic props spreader we tap into? From what I understand, we are now leaking the implementation details of the column resizing feature to the view (if we want to make it composable, the view shouldn't know anything about this column resize feature).
There was a problem hiding this comment.
Well, this is the current way of building the grid and linking hooks to components.
In the previous implementation, all children from root had to forward a prop that they didn't need to be aware of to their child, which is property drilling and impact on component portability.
This way if you replace the full column header you can still use the resize functionality through the apiRef, and none of the components need to be aware of the separator props.
We might refactor that when do more refactoring on component customization but ATM, it's nice to have everything working in a homogeneous way.
There was a problem hiding this comment.
Sure for the current way of doing things. I was more interested in the long term direction. I was under the assumption that a generic props drilling would allow portability, make customizations easier. Isn't it how downshift and react-table behave? They have wildcard props you need to spread on specific components, input, pop-up, wrapper, header cell, etc.
There was a problem hiding this comment.
Props drilling doesn't bring portability as if you change the component structure you have to change the props, and maybe add more drilling and so on... Also, it doesn't scale, imagine you have 20 props to pass around, then need to refactor, hell!
For downshift, it seems that they pass a bunch of functions to a children function that the react tree can use. However if a root component contains another component within it, it might need some props that are unrelated to itself. So it would have 2 options either forward the prop or use the context. The latter is better, as it doesn't need to be aware of its child component props, it's more portable and it's more scalable. So basically that's what we do through the apiRef.
We can imagine a more flexible approach to customization but that would be another PR and discussion.
dtassone
changed the title
zannager
added
the
component: data grid
No description provided.