Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGridPremium] Add support for lazy-loading #7124

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

m4theushw
Copy link
Member

Fixes #7112

#5214 didn't include the lazy-loading hook in DataGridPremium.

@m4theushw m4theushw added the component: data grid This is the name of the generic UI component, not the React module! label Dec 7, 2022
@mui-bot
Copy link

mui-bot commented Dec 7, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-7124--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 638.7 986.8 829.8 801.78 140.208
Sort 100k rows ms 700.2 1,184.2 700.2 920.84 188.208
Select 100k rows ms 204.4 293.6 263 254.88 31.983
Deselect 100k rows ms 147.5 310.6 174 199.38 61.14

Generated by 🚫 dangerJS against ae3fbef

@cherniavskii cherniavskii added plan: Premium Impact at least one Premium user bug 🐛 Something doesn't work labels Dec 7, 2022
@m4theushw m4theushw added the needs cherry-pick The PR should be cherry-picked to master after merge label Dec 7, 2022
@m4theushw m4theushw merged commit d2cf267 into mui:next Dec 7, 2022
@cherniavskii
Copy link
Member

We should backport it to the master branch as well

@m4theushw m4theushw deleted the lazy-loading-premium branch December 7, 2022 23:05
m4theushw added a commit to m4theushw/mui-x that referenced this pull request Dec 7, 2022
m4theushw added a commit to m4theushw/mui-x that referenced this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! needs cherry-pick The PR should be cherry-picked to master after merge plan: Premium Impact at least one Premium user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] Does premium component support lazy loading?
3 participants