Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation on #722, the changes:
@testing-library/react
are not allowed, we proxy them all withtest/utils
. I have added an eslint rule to fail the CI and had to switch a test tostrict: false
, this test doesn't work in strict mode. It's important we know about it, the underlying logic of the grid is likey incorrect.../../..
, we use absolute imports from the root for simplicity./tests
folder for consistency with DataGrid.test/utils/index
in the main repo. I have added an eslint rule to fail the CI for consistency.async () => {
.Motived by seeing the same issues in #715, this PR should come before #715.