Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Playwright #7240

Merged
merged 3 commits into from
Dec 30, 2022
Merged

Bump Playwright #7240

merged 3 commits into from
Dec 30, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 18, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence Type Update
@playwright/test (source) 1.27.1 -> 1.29.1 age adoption passing confidence devDependencies minor
mcr.microsoft.com/playwright v1.27.1-focal -> v1.29.1-focal age adoption passing confidence docker minor
playwright (source) ^1.27.1 -> ^1.29.1 age adoption passing confidence devDependencies minor
playwright (source) ^1.27.1 -> ^1.29.1 age adoption passing confidence dependencies minor

Release Notes

Microsoft/playwright

v1.29.1

Compare Source

Highlights

https://github.com/microsoft/playwright/issues/18928 - [BUG] Electron firstWindow times out after upgrading to 1.28.0https://github.com/microsoft/playwright/issues/192466 - [BUG] Electron firstWindow times out after upgrading to 1.28.https://github.com/microsoft/playwright/issues/1941212 - [REGRESSION]: 1.28 does not work with electron-serve anymorhttps://github.com/microsoft/playwright/issues/19540540 - [BUG] electron.app.getAppPath() returns the path one level higher if you run electron pointing to the directhttps://github.com/microsoft/playwright/issues/195489548 - [REGRESSION]: Ubuntu 18 LTS not supported anymore

Browser Versions

  • Chromium 109.0.5414.46
  • Mozilla Firefox 107.0
  • WebKit 16.4

This version was also tested against the following stable channels:

  • Google Chrome 108
  • Microsoft Edge 108

v1.29.0

Compare Source

New APIs
  • New method route.fetch() and new option json for route.fulfill():

    await page.route('**/api/settings', async route => {
      // Fetch original settings.
      const response = await route.fetch();
    
      // Force settings theme to a predefined value.
      const json = await response.json();
      json.theme = 'Solorized';
    
      // Fulfill with modified data.
      await route.fulfill({ json });
    });
  • New method locator.all() to iterate over all matching elements:

    // Check all checkboxes!
    const checkboxes = page.getByRole('checkbox');
    for (const checkbox of await checkboxes.all())
      await checkbox.check();
  • Locator.selectOption matches now by value or label:

    <select multiple>
      <option value="red">Red</div>
      <option value="green">Green</div>
      <option value="blue">Blue</div>
    </select>
    await element.selectOption('Red');
  • Retry blocks of code until all assertions pass:

    await expect(async () => {
      const response = await page.request.get('https://api.example.com');
      await expect(response).toBeOK();
    }).toPass();

    Read more in our documentation.

  • Automatically capture full page screenshot on test failure:

    // playwright.config.ts
    import type { PlaywrightTestConfig } from '@&#8203;playwright/test';
    
    const config: PlaywrightTestConfig = {
      use: {
        screenshot: {
          mode: 'only-on-failure',
          fullPage: true,
        }
      }
    };
    
    export default config;
Miscellaneous
Browser Versions
  • Chromium 109.0.5414.46
  • Mozilla Firefox 107.0
  • WebKit 16.4

This version was also tested against the following stable channels:

  • Google Chrome 108
  • Microsoft Edge 108

v1.28.1

Compare Source

Highlights

This patch release includes the following bug fixes:

https://github.com/microsoft/playwright/issues/18928 - [BUG] Electron firstWindow times out after upgrading to 1.28.0https://github.com/microsoft/playwright/issues/189200 - [BUG] [expanded=false] in role selector returns elements without aria-expanded attribuhttps://github.com/microsoft/playwright/issues/18865865 - [BUG] regression in killing web server process in 1.28.0

Browser Versions

  • Chromium 108.0.5359.29
  • Mozilla Firefox 106.0
  • WebKit 16.4

This version was also tested against the following stable channels:

  • Google Chrome 107
  • Microsoft Edge 107

v1.28.0: v1.28

Compare Source

Playwright Tools

  • Record at Cursor in VSCode. You can run the test, position the cursor at the end of the test and continue generating the test.
New VSCode Extension
  • Live Locators in VSCode. You can hover and edit locators in VSCode to get them highlighted in the opened browser.
  • Live Locators in CodeGen. Generate a locator for any element on the page using "Explore" tool.
Locator Explorer
  • Codegen and Trace Viewer Dark Theme. Automatically picked up from operating system settings.
Dark Theme
Test Runner
New APIs
Browser Versions
  • Chromium 108.0.5359.29
  • Mozilla Firefox 106.0
  • WebKit 16.4

This version was also tested against the following stable channels:

  • Google Chrome 107
  • Microsoft Edge 107

Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Update of dependencies label Dec 18, 2022
@mui-bot
Copy link

mui-bot commented Dec 18, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-undefined--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 650.9 1,183.1 669.3 835.5 212.512
Sort 100k rows ms 591.1 1,111.1 591.1 883.92 194.007
Select 100k rows ms 232 313.2 305.2 285.98 30.768
Deselect 100k rows ms 168.8 331.2 227.1 235.24 60.885

Generated by 🚫 dangerJS against 1a0da4e

@renovate
Copy link
Contributor Author

renovate bot commented Dec 29, 2022

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@flaviendelangle flaviendelangle merged commit e8be2db into next Dec 30, 2022
@flaviendelangle flaviendelangle deleted the renovate/playwright branch December 30, 2022 10:09
@flaviendelangle
Copy link
Member

@cherniavskii I went a little to fast on this one
Did you finish the fixes or should I revert it ?

@cherniavskii
Copy link
Member

There is a regression in Chrome print view, I've added the fix to solve it: https://github.com/mui/mui-x/pull/7240/files#diff-367da2712f1be3435db09886c94eef7f6b2f4d7e9eafeff76695f3195151d510R133

There's still a small visual regression, but I didn't find a quick fix for it and I think it's fine like that:
Screenshot 2022-12-30 at 20 50 31

I don't think we should revert the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants