-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Start documentation for the data grid filter features #754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start, I really appreciate that have you split the work into multiple chunks! It seems that you have focused here on doing half of the structure drawn in #644 :)
- We can remove the 🚧 icon liked to the filtering feature: in the side nav and in the feature comparison
- One of the new demo turns my CPU into a 🍳 maker
docs/src/pages/components/data-grid/filtering/CustomRatingFilterOperator.tsx
Outdated
Show resolved
Hide resolved
docs/src/pages/components/data-grid/filtering/CustomRatingFilterOperator.tsx
Outdated
Show resolved
Hide resolved
docs/src/pages/components/data-grid/filtering/BasicFilteringGrid.tsx
Outdated
Show resolved
Hide resolved
docs/src/pages/components/data-grid/filtering/CustomRatingFilterOperator.tsx
Outdated
Show resolved
Hide resolved
|
||
## 🚧 Quick filter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove this section? Don't we still want to implement quick filtering?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but we can add it later...
Just wanted to cleanup the page, but I can put it back, not an issue :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my perspective, it depends on the following: do we want to implement this feature no matter what, and do we think it's important?
If the answer is yes to these two conditions, then I think we should keep linking the issue so we can use it to prioritize the roadmap. If the answer is no, then we probably want to remove the link, to no skewed the 👍 on the linked issue more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also add a new page with all the issues in progress so ppl can upvote issues from a central location
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a new page with all the issues in progress
I think it's the option 2 mentioned before. We have this page, it's GitHub's issues, that we could maybe link a bit better, by mentioning it in the roadmap page: https://material-ui.com/discover-more/roadmap/.
docs/src/pages/components/data-grid/filtering/CustomRatingFilterOperator.tsx
Outdated
Show resolved
Hide resolved
docs/src/pages/components/data-grid/filtering/CustomRatingFilterOperator.tsx
Outdated
Show resolved
Hide resolved
docs/src/pages/components/data-grid/filtering/CustomRatingFilterOperator.tsx
Outdated
Show resolved
Hide resolved
Yes I noticed some issues as well but it does not seem to occur all the time, I'm investigating |
a2784d7
to
a27663d
Compare
a27663d
to
2ec66a7
Compare
Co-authored-by: Matt <github@nospam.33m.co>
Related to #201
WIP structure: