Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TimePicker] Add missing themeAugmentation entry #7732

Merged

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Jan 27, 2023

Fix #7730

@LukasTy LukasTy added bug 🐛 Something doesn't work typescript component: pickers This is the name of the generic UI component, not the React module! component: TimePicker The React component. labels Jan 27, 2023
@LukasTy LukasTy self-assigned this Jan 27, 2023
@mui-bot
Copy link

mui-bot commented Jan 27, 2023

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 509.7 900.4 797.7 707.12 164.484
Sort 100k rows ms 623.7 1,068 766 881.72 162.659
Select 100k rows ms 206 287.7 227.8 237.06 27.717
Deselect 100k rows ms 152.7 205.3 164.2 175.7 23.182

Generated by 🚫 dangerJS against 42ff436

Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if it would not be easier to automate the generation of those files

@LukasTy
Copy link
Member Author

LukasTy commented Jan 27, 2023

I'm wondering if it would not be easier to automate the generation of those files

Yup, I believe we could look into that. 🙈
I was looking into coming up with a type, which would enforce themeAugmentation.spec to contain all the components from props file, but that is tedious to do and could still allow for human error 🤔

@LukasTy LukasTy merged commit 0cf9b3d into mui:master Jan 27, 2023
@LukasTy LukasTy deleted the add-missing-time-picker-theme-augmentation branch January 27, 2023 17:16
@LukasTy
Copy link
Member Author

LukasTy commented Feb 9, 2023

Ended up with a different approach (#7808) preventing the ability to introduce errors in d.ts files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! component: TimePicker The React component. typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants