-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Upgrade monorepo #7849
[core] Upgrade monorepo #7849
Conversation
These are the results for the performance tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
Maybe Netlify step just a fluke and you only need to re-run the pipeline? 🤔 🙈
version "5.10.16" | ||
resolved "https://github.com/mui/material-ui.git#2abad795e4890829deb0fb40204a100b547a3873" | ||
version "5.11.8" | ||
resolved "https://github.com/mui/material-ui.git#c0c3d556a4d039f615188ecc5be6123f6de9156b" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's odd, I still see the v6-alpha
in the deployment preview even though the resolved monorepo version points straight to the merge commit with this change: mui/material-ui@c0c3d55
cc @LukasTy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm... Interesting issue.
I've experienced the same locally, until I've deleted .next
folder and restarted the dev server. 🤔
Maybe it's the same in Netlify? It might cache the built resources somewhere until you forcefully remove them. 🙈
TL.DR.: I think it should be fine when new docs are deployed. 🙈
EDIT: It could possibly be asserted by (re)creating a PR from this branch to trigger a deployment on a different "domain"/path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've experienced the same locally, until I've deleted .next folder and restarted the dev server. 🤔
That is what I did locally too, but I didn't expect to see this problem in a preview deployment.
To include banner from mui/material-ui#36074