[DataGrid] Fix behavior of the hideFooter prop

[dtassone]

No description provided.

[oliviertassinari]

"good first issue" are meant to help onboard contributions from the community. If core team members are working on them, it makes them useless. The objective is to hopefully grow open source contributors on the MIT side. If react-table has 260 contributors, material-table 162, there is no reason we can't have a similar amount with the MIT DataGrid component.

[dtassone]

"good first issue" are meant to help onboard contributions from the community. If core team members are working on them, it makes them useless. The objective is to hopefully grow open source contributors on the MIT side. If react-table has 260 contributors, material-table 162, there is no reason we can't have a similar amount with the MIT DataGrid component.

I know, but as I was around the area, I felt bad not fixing it.

[DanailH]

Just a note - it makes sense to do the same for the showToolbar prop.

[oliviertassinari]

it makes sense to do the same for the showToolbar prop.

Aren't the toolbar and the header two different notions? Like footer and pagination, one is inside the other?

How about we don't touch this area as we will remove the showToolbar prop in the near future?

[dtassone]

it makes sense to do the same for the showToolbar prop.

Aren't the toolbar and the header two different notions? Like footer and pagination, one is inside the other?

Yes it is as to override the toolbar, you have to use the header component

How about we don't touch this area as we will remove the showToolbar prop in the near future?

Reverted

[oliviertassinari]

@dtassone Regarding the format of the pull request, it would be better if we were following the other ones. For instance, #821 is still open.

In the round-robin for the release, you are next for making the release, hopefully, you will see the impact of the current pull request title :).