[datagrid] onRowsScrollEnd should trigger even if initial data row heights is less than table height
#8479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewNetlify deploy preview: https://deploy-preview-8479--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
yaredtsy
changed the title
onRowsScrollEnd to trigger even when initial data row heights is less than table heightonRowsScrollEnd should trigger even if initial data row heights is less than table height
zannager
added
the
component: data grid
|
We plan to rework this event to use |
|
(I have added the review request to remove the PR from https://tools-public.onrender.com/prod/pages/1t353h04) |
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
|
Closing this one since the issue has been resolved in #8672 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4184
Problem
Currently, the
onRowsScrollEndfunction is not triggering if the initial data row height is less than the table height. This is because, afteronRowsScrollEndis called once, it must leave the bottom area to be called again so that it will not be fired infinitely.solution
Set
isInScrollBottomAreato false when new rows are being added, indicating that the scroll position is no longer at the bottom of the content.before https://codesandbox.io/s/sleepy-farrell-uo38ju?file=/demo.tsx
after https://codesandbox.io/s/jovial-glitter-k9ok92?file=/demo.tsx