Use api ref #86
Use api ref #86
Conversation
|
This one will not be green as we need to publish the package to fix it |
When should we fix this requirement? Maybe we should open an issue about it to keep track of the problem? (It's not OK that we need to publish the component to get the latest update on the documentation preview). |
Yes we can open an issue. Netlify don't know how to manage monorepos properly yet so if you do a breaking changes on the grid then the storybook and the demo app will be broken until you publish the pkgs |
From what I understand, this is the same problem than we have current on requiring to build the components + yarn link in development in order to render them in the storybook. We solve that, we solve Netlify build at the same time. For the solution, I would suggest we copy & paste the one from the main repo, no need to innovate. I have added a mention to this problem in #50 |
|
Merged and will release |
| @@ -1,7 +1,7 @@ | |||
| import * as React from 'react'; | |||
| import { fromEvent, Subscription } from 'rxjs'; | |||
| import { takeUntil, tap } from 'rxjs/operators'; | |||
| import { XGrid, ColDef, GridApi, GridOptionsProp } from '@material-ui/x-grid'; | |||
| import { XGrid, ColDef, GridOptionsProp, useApiRef } from '@material-ui/x-grid'; | |||
There was a problem hiding this comment.
Regarding the name of the modules, I'm pretty confident that they should be prefixed with Grid to avoid all future conflict of modules from @material-ui/x, unless there is almost no chance we have a component with the same name, or type.
import { XGrid, GridColDef, GridOptionsProp, useGridApiRef } from '@material-ui/x-grid';
oliviertassinari
added
the
component: data grid
No description provided.