Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGridPremium] Fix infinite loop when updating grouped rows #8693

Merged

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Apr 20, 2023

@cherniavskii cherniavskii added component: data grid This is the name of the generic UI component, not the React module! regression A bug, but worse plan: Premium Impact at least one Premium user feature: Row grouping Related to the data grid Row grouping feature labels Apr 20, 2023
@mui-bot
Copy link

mui-bot commented Apr 20, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-8693--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 649.8 1,013.5 649.8 860.86 136.508
Sort 100k rows ms 661.3 1,438.6 1,091.3 1,057.12 247.835
Select 100k rows ms 213.6 412.9 317.6 322.6 69.252
Deselect 100k rows ms 153.3 290.1 244.2 226.1 56.736

Generated by 🚫 dangerJS against 1b7462e

@cherniavskii cherniavskii marked this pull request as ready for review April 20, 2023 18:36
@kavitang
Copy link

Wanted to know when this will be merged as it's a possible blocker for our issue #8580 . Would appreciate an update here so we can plan on how to proceed with this.Thanks!

@cherniavskii
Copy link
Member Author

Misclick 😅

@cherniavskii
Copy link
Member Author

Hey @kavitang
We'll merge it as soon as it passes the review, hopefully, this week :)

@kavitang
Copy link

Hey @kavitang We'll merge it as soon as it passes the review, hopefully, this week :)

Thanks @cherniavskii looking forward to it!

Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recursion problems often give a hard time debugging, thank you for identifying and fixing it 👍

@cherniavskii cherniavskii merged commit 28b3164 into mui:master Apr 26, 2023
@cherniavskii cherniavskii deleted the fix-infinite-loop-on-rows-update branch April 26, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Row grouping Related to the data grid Row grouping feature plan: Premium Impact at least one Premium user regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data grid] Updating grouped rows results in infinite loop
4 participants