-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGridPremium] Fix infinite loop when updating grouped rows #8693
[DataGridPremium] Fix infinite loop when updating grouped rows #8693
Conversation
Netlify deploy previewNetlify deploy preview: https://deploy-preview-8693--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
Wanted to know when this will be merged as it's a possible blocker for our issue #8580 . Would appreciate an update here so we can plan on how to proceed with this.Thanks! |
Misclick 😅 |
Hey @kavitang |
Thanks @cherniavskii looking forward to it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recursion problems often give a hard time debugging, thank you for identifying and fixing it 👍
Fixes #8626
Before: https://codesandbox.io/s/competent-neumann-kx9weo
After: https://codesandbox.io/s/currying-snowflake-sk4nyu
Before: https://codesandbox.io/s/loving-darwin-j53ffh
After: https://codesandbox.io/s/awesome-mclaren-6w4f6v
Also reported in #8580 (comment)