Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Extract baseChip slot #8748

Merged
merged 3 commits into from
May 11, 2023
Merged

[DataGrid] Extract baseChip slot #8748

merged 3 commits into from
May 11, 2023

Conversation

cherniavskii
Copy link
Member

No description provided.

@cherniavskii cherniavskii added the component: data grid This is the name of the generic UI component, not the React module! label Apr 25, 2023
@mui-bot
Copy link

mui-bot commented Apr 25, 2023 •
edited
Loading

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-8748--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 657.9 1,167 823.8 902.02 166.015
Sort 100k rows ms 713.1 1,205.7 1,205.7 1,014.2 182.194
Select 100k rows ms 241.9 473.7 313.4 341.14 79.51
Deselect 100k rows ms 157.5 245.9 205 207.78 30.534

Generated by 🚫 dangerJS against 111fc8f

siriwatknp
siriwatknp approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

@cherniavskii cherniavskii added the customization: css Design CSS customizability label May 1, 2023
@cherniavskii cherniavskii marked this pull request as ready for review May 1, 2023 16:48
@cherniavskii cherniavskii requested a review from MBilalShafi May 1, 2023 16:48
@cherniavskii cherniavskii merged commit e78f8c5 into mui:master May 11, 2023
@cherniavskii cherniavskii deleted the extract-Chip-slot branch May 11, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@MBilalShafi MBilalShafi MBilalShafi approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! customization: css Design CSS customizability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cherniavskii @mui-bot @MBilalShafi @siriwatknp