[test] Cover row grouping regression with a unit test #8870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherniavskii
added
test
component: data grid
Netlify deploy previewNetlify deploy preview: https://deploy-preview-8870--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
1 task
MBilalShafi
approved these changes
May 5, 2023
| expect(getColumnValues(3)).to.deep.equal(['', 'username1', 'username2']); | ||
|
|
||
| // trigger row update without any changes in row data | ||
| act(() => apiRef.current.updateRows([{ id: 1 }])); |
There was a problem hiding this comment.
Should we also try an actual data update (lets say username2 => username2 updated)
There was a problem hiding this comment.
There already is a test that covers an actual update:
In the regression covered by the test in this PR, the row was reordered even if there were no actual updates to the row - that's why I wrote it this way 🙂
cherniavskii
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers #8853 that was fixed in #8823