[core] Lock @types/node on v18
#9107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasTy
commented
May 24, 2023
| resolved "https://registry.yarnpkg.com/@types/node/-/node-20.1.4.tgz#83f148d2d1f5fe6add4c53358ba00d97fc4cdb71" | ||
| integrity sha512-At4pvmIOki8yuwLtd7BNHl3CiWNbtclUbNtScGx4OHfBd4/oWoJC8KRCIxXwkdndzhxOsPXihrsOoydxBjlE9Q== | ||
|
|
||
| "@types/node@^14.0.1": |
There was a problem hiding this comment.
We don't really care about this as it is coming from https://github.com/C2FO/fast-csv/blob/master/packages/format/package.json#L40 and looks like an oversight/bug.
Netlify deploy previewNetlify deploy preview: https://deploy-preview-9107--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
flaviendelangle
approved these changes
May 25, 2023
1 task
This was referenced Jul 11, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9060
Address #9060 (review)
Locking it on v18 as we plan to stick with v18 (current LTS) for CI as discussed here mui/material-ui#37173