Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Improve German (de-DE) locale #9259

Merged
merged 1 commit into from
Jun 8, 2023
Merged

[l10n] Improve German (de-DE) locale #9259

merged 1 commit into from
Jun 8, 2023

Conversation

ximex
Copy link
Contributor

@ximex ximex commented Jun 7, 2023 •
edited
Loading

@ximex ximex changed the title improve de-DE l10n for x-data-grid [l10n] Improve German (de-DE) locale Jun 7, 2023
@mui-bot
Copy link

mui-bot commented Jun 7, 2023 •
edited
Loading

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running yarn l10n
  • Clean files with yarn prettier.

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9259--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 579.4 1,062.7 625.2 725.96 175.439
Sort 100k rows ms 503.8 928.7 782.6 757.94 139.463
Select 100k rows ms 177.9 309.8 216.9 233.42 48.399
Deselect 100k rows ms 128.9 276.8 201.6 199.36 48.383

Generated by 🚫 dangerJS against 6454099

@zannager zannager added the l10n localization label Jun 8, 2023
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged labels Jun 8, 2023
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 8, 2023
alexfauquette
alexfauquette approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 🎉

@LukasTy LukasTy added the component: data grid This is the name of the generic UI component, not the React module! label Jun 8, 2023
@alexfauquette alexfauquette merged commit 577ac5c into mui:master Jun 8, 2023
@ximex ximex deleted the x-data-grid-l10n-deDE branch June 8, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ximex @mui-bot @alexfauquette @LukasTy @zannager