[DataGrid] Fix footer visual regression #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dtassone How can we reproduce the issue? |
https://material-ui-x.netlify.app/storybook/?path=/story/x-grid-tests-pagination--pagination-default You need a grid bigger than 960px |
There was a problem hiding this comment.
Thanks for sharing the reproduction. If you could share it by default in the PR description, it would be even better.
It could track the regression coming from https://github.com/mui-org/material-ui-x/pull/508/files#diff-a285df775e3924231145e4304c32f2505d030391e3f3a76fe9ff6d342191dcd1R29.
oliviertassinari
changed the title
oliviertassinari
added
bug 🐛
oliviertassinari
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix input display:
Visible on grid with width higher than 960px, ie.
https://material-ui-x.netlify.app/storybook/?path=/story/x-grid-tests-pagination--pagination-default