[DataGrid] Fix strict mode issue with apiRef #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtassone
changed the title
oliviertassinari
requested changes
Jan 27, 2021
DanailH
approved these changes
Jan 28, 2021
|
|
||
| export const decorators = [ | ||
| (Story) => ( | ||
| <React.StrictMode> |
There was a problem hiding this comment.
So not using storybookjs/storybook#12734 😆
There was a problem hiding this comment.
Nope! I tried but it didn't seem to work
oliviertassinari
added
bug 🐛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have activated strict mode on these 2 stories. The main issue occurred when passing the apiRef as a prop. It is now fixed
http://localhost:6006/?path=/story/x-grid-tests-state--strict-demo
http://localhost:6006/?path=/story/x-grid-tests-pagination--pagination-api-tests
Todo:
Fix #849
Fix codesandbox https://codesandbox.io/s/create-react-app-forked-kcoup?file=/src/App.js