Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Add TimeRangePicker component #9431

Draft
wants to merge 60 commits into
base: master
Choose a base branch
from
Draft

[pickers] Add TimeRangePicker component #9431

wants to merge 60 commits into from
+5,237 −96

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Jun 23, 2023 •
edited
Loading

@flaviendelangle flaviendelangle added the component: pickers This is the name of the generic UI component, not the React module! label Jun 23, 2023
@flaviendelangle flaviendelangle self-assigned this Jun 23, 2023
@mui-bot
Copy link

mui-bot commented Jun 23, 2023 •
edited
Loading

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-9431--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 7f6b251

LukasTy
LukasTy reviewed Sep 14, 2023
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving some minor observations here. 🙈

docs/data/date-pickers-component-api-pages.ts Show resolved Hide resolved
packages/x-date-pickers-pro/src/index.ts Show resolved Hide resolved
packages/x-date-pickers-pro/src/TimeRangePicker/shared.tsx Outdated Show resolved Hide resolved
packages/x-date-pickers-pro/src/MobileTimeRangePicker/MobileTimeRangePicker.tsx

const props = {
...defaultizedProps,
// TODO: Do we want the toolbar to support AM/PM switch on mobile?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably no, unless we go with the AnalogClock on Mobile. 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the plan is to have the digital clock on mobile for range pickers and the analog clock on mobile for TimePicker / DateTimePicker ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we'd go with the proposed designs - it would seem so, but that is still up for debate. 🙈

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the component ready for mobile?

I'm 100% in favor of doing it. But if we do it, for me it means that in the future we will use the digital clock on the MobileTimePicker.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the component ready for mobile?

It had some issues, which I tried addressing in the DateTimeRangePicker PR.

I'm 100% in favor of doing it. But if we do it, for me it means that in the future we will use the digital clock on the MobileTimePicker.

That part we still need to align on the Design and Product side. I'm also for consistency, but we currently do not seem to have a singular position that everyone agrees on. 🙈

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can focus our next Monday meeting on this topic 👌

Concerning the rendererInterceptor, it's not easy to understand what is the goal but I'll wait to have the JSDoc to have a 2nd look 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can focus our next Monday meeting on this topic 👌

Oh yes, that's one of the last pressing design matters for the range pickers.

Concerning the rendererInterceptor, it's not easy to understand what is the goal but I'll wait to have the JSDoc to have a 2nd look 👍

Don't pay too much attention to it. That was my alpha implementation for configurable view renderer support and handling view combination (DateRangeCalendar on the left and MultiSectionDigitalClock or any other timeViewRenderer on the right).

packages/x-date-pickers-pro/src/DesktopTimeRangePicker/DesktopTimeRangePicker.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 16, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 26, 2023
@LukasTy LukasTy assigned LukasTy and unassigned flaviendelangle May 17, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 17, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 21, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 22, 2024
@LukasTy LukasTy changed the title [pickers] New component: TimeRangePicker [pickers] Add TimeRangePicker component May 22, 2024
@LukasTy LukasTy added new feature New feature or request plan: Pro Impact at least one Pro user labels May 22, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 24, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@LukasTy LukasTy

Labels
component: pickers This is the name of the generic UI component, not the React module! new feature New feature or request plan: Pro Impact at least one Pro user v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pickers] New component: TimeRangePicker
3 participants
@flaviendelangle @mui-bot @LukasTy