Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve the docs for the filtering feature #945

Merged
merged 11 commits into from
Jan 29, 2021

Conversation

dtassone
Copy link
Member

@dtassone dtassone commented Jan 28, 2021

Fix #201

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
fix text

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Matt <github@nospam.33m.co>
@oliviertassinari oliviertassinari changed the title [Docs] Filter doc more [docs] Filter doc more Jan 28, 2021
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jan 28, 2021
@oliviertassinari oliviertassinari changed the title [docs] Filter doc more [docs] Improve the docs for the filtering feature Jan 28, 2021
@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Jan 28, 2021
dtassone and others added 5 commits January 29, 2021 11:45

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
…ator.tsx

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left two comments to improve the existing demos (less confusion & more performant demos), otherwise, looks good.

@dtassone dtassone removed the request for review from mbrookes January 29, 2021 13:44
@dtassone dtassone merged commit 506148b into mui:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataGrid] Implement multi-column filter
3 participants