[DataGrid] Fix column reorder instability #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add a test case for this one? |
oliviertassinari
added
component: data grid
oliviertassinari
requested changes
Jan 29, 2021
There was a problem hiding this comment.
I don't think that the test case is correct, 2 issues with it:
- It doesn't fail on HEAD (so it's testing something but not our problem)
- A simplified reproduction: https://codesandbox.io/s/material-demo-forked-4s6qs?file=/package.json (reorder two columns and click on the button). It seems related to the reordering feature, not the selection.
dtassone
force-pushed
the
fixOnSelectionChange
branch
from
c1e633a to
5c31628
Compare
Yes I knew, it's fixed now |
oliviertassinari
changed the title
oliviertassinari
requested changes
Feb 1, 2021
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
oliviertassinari
approved these changes
Feb 1, 2021
oliviertassinari
added a commit
to oliviertassinari/mui-x
that referenced
this pull request
Feb 3, 2021
This reverts commit 64ba484.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #936