-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Add bgBG locale #983
[DataGrid] Add bgBG locale #983
Conversation
…e/DataGrid-777-add-otb-locale
packages/grid/_modules_/grid/components/panel/filterPanel/FilterForm.tsx
Outdated
Show resolved
Hide resolved
A side question, will the documentation be added (https://material-ui.com/components/data-grid/localization/#locale-text) when we work on #984? |
Yes, I would like to make a demo with the theme I think it will be nice to showcase how it works. As part of this ticket, I can extend the docs saying we have 1 or some OTB locales and point to GitHub for those who would like to contribute, what do you think @oliviertassinari? |
@DanailH No specific preferences on having a live demo. I see equal pros & cons so why not. Linking the folder where the locales are sounds like a great tradeoff. It removes the need to keep a table up to date as we do in for the core component (contributors often forget to update it). |
docs/src/pages/components/data-grid/localization/localization.md
Outdated
Show resolved
Hide resolved
docs/src/pages/components/data-grid/localization/localization.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
Fixes #777
This PR adds 'bgBG' locale OTB. Currently, if you want to use that locale you would need to provide it to the grid in the following way:
The reason is that we want to make it work with
createMuiTheme
and this is the v5 structure https://material-ui.com/guides/localization/#locale-text - #984In a separate PR I'll add the ability to set the locale using
createMuiTheme
because currently, we are missing an identifier for the grid, a.k.aMuiDataGrid
.PS: I found that I missed a couple of labels so I added them as well.