[example] Update vite example #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the template to the latest vitejs starter. It also fixes an issue with Pigment initialization in dev mode by explicitly installing prop-types and react-is and adding it to the optimizeDeps' `include` list. This won't be an issue when we don't use prop-types in the stable v1 release.
brijeshb42
force-pushed
the
vite-example-update
branch
from
a72aaca to
5ffd8ff
Compare
siriwatknp
approved these changes
Nov 5, 2024
| "preview": "vite preview" | ||
| }, | ||
| "dependencies": { | ||
| "@pigment-css/react": "latest", | ||
| "prop-types": "latest", |
There was a problem hiding this comment.
Does it need to be a dependency? As a developer who clones a TypeScript examples, the first thing I would likely do is try to remove this line.
oliviertassinari
added
bug 🐛
1 task
brijeshb42
pushed a commit
to brijeshb42/material-ui
that referenced
this pull request
Nov 21, 2024
Originally fixed here mui/pigment-css#300
brijeshb42
pushed a commit
to brijeshb42/material-ui
that referenced
this pull request
Nov 21, 2024
Originally fixed here mui/pigment-css#300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the template to the latest Vite starter. It also fixes an issue with Pigment initialization in dev mode by explicitly installing
prop-typesandreact-isand adding it to theoptimizeDeps'includelist. This won't be an issue when we don't useprop-typesin the stable v1 release.Fixes #291