Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme): Allow listing values with number keys #360

Merged
merged 1 commit into from
Jan 6, 2025
Merged

fix(theme): Allow listing values with number keys #360

merged 1 commit into from
Jan 6, 2025

Conversation

brijeshb42
Copy link
Contributor

@brijeshb42 brijeshb42 commented Dec 30, 2024 •
edited
Loading

Currently, the ThemeKey type only enumerates keys that are string. This PR changes that to also include number keys. See theme.spec.ts.

@brijeshb42 brijeshb42 requested a review from mnajdova December 30, 2024 15:02
@brijeshb42 brijeshb42 added the package: theme Specific to @pigment-css/theme label Dec 30, 2024
@brijeshb42 brijeshb42 added this to the Road to v1 milestone Dec 30, 2024
@brijeshb42 brijeshb42 force-pushed the fix/theme-number-keys branch from a25f5e7 to d4f2c6a Compare December 30, 2024 15:09
@brijeshb42 brijeshb42 force-pushed the fix/theme-number-keys branch from d4f2c6a to 8f013a1 Compare December 30, 2024 15:14
@brijeshb42 brijeshb42 merged commit a92097b into mui:master Jan 6, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
package: theme Specific to @pigment-css/theme
Projects
None yet
Milestone
Road to v1
Development

Successfully merging this pull request may close these issues.
2 participants
@brijeshb42 @mnajdova