Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connections should be global #1065

Closed
2 tasks done
prakhargupta1 opened this issue Sep 29, 2022 · 6 comments
Closed
2 tasks done

Connections should be global #1065

prakhargupta1 opened this issue Sep 29, 2022 · 6 comments
Assignees
Labels
design: ui Design design: ux Design feature: Connections PostgreSQL, MySQL, etc. new feature New feature or request

Comments

@prakhargupta1
Copy link
Member

prakhargupta1 commented Sep 29, 2022

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

Currently, our connections are inside the app. So for each app user has to create a connection. But I think connection should be app agnostic and once connected to a data source, all apps should have access to that data source. Later on in granular access control, we can limit its access.

If the connection isn't set it should not show inside the app when forming a query.

From the UI perspective, we could do something like:

Screenshot 2022-09-29 at 1 13 12 PM

This will clean up the app building experience, and we'll have the room to condense pages to the top left and queries to the left bar.

Note: This isn't a problem so far, so if we decide to do it, we can plan it later.

@prakhargupta1 prakhargupta1 added new feature New feature or request design: ui Design design: ux Design feature: Connections PostgreSQL, MySQL, etc. waiting for 👍 Waiting for upvotes labels Sep 29, 2022
@WangLarry
Copy link

@prakhargupta1
I notice these connections run on server side. App query through next.js api to get data.

@apedroferreira
Copy link
Member

@prakhargupta1 I notice these connections run on server side. App query through next.js api to get data.

Hi @WangLarry - yes, that is in general how our connections and queries work.
We believe it should be possible to have them keep working like that but be globally defined on a user account level, instead of being specific to each app.

@WangLarry
Copy link

WangLarry commented Sep 29, 2022

yes.
Query defination should be in app level. Query node is in page level. On client side, react-query cache same request's result already.
Connect template( have not yet) is over app level or in library. Connect template: google api, facebook api etc. App should config some params (clientId ...) of template when using it.

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 23, 2022

The direction toward moving the connections to be global makes sense to me. I think that it feels a bit similar to moving toward the direction of a mono repository: you get global services that you can use from many different locations, you can update everything at once.

I think that this direction could also help in an environment where you have a staff with different technical skills that build these simple applications. A strong backend engineer might do the setup while a product manager might, later on, create a few new pages.

Even in real life, for MUI internal's needs, I have Zendesk configured twice 🙃:

@Janpot
Copy link
Member

Janpot commented Nov 23, 2022

I opened a discussion which allows to collaborate on this under threads #1376

@prakhargupta1 prakhargupta1 pinned this issue Dec 12, 2022
@prakhargupta1 prakhargupta1 unpinned this issue Jan 17, 2023
@prakhargupta1
Copy link
Member Author

I am closing this issue as it is not relevant anymore. Now each Toolpad app has multiple pages and all can share a connection, so in a way in the scope of the project, the connection is global.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design: ui Design design: ux Design feature: Connections PostgreSQL, MySQL, etc. new feature New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants