Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp queries UI #1261

Open
2 tasks done
prakhargupta1 opened this issue Nov 1, 2022 · 3 comments
Open
2 tasks done

Revamp queries UI #1261

prakhargupta1 opened this issue Nov 1, 2022 · 3 comments
Labels
design: ui Design design: ux Design feature: Queries Making new API requests scope: toolpad-studio Abbreviated to "studio" umbrella For grouping multiple issues to provide a holistic view

Comments

@prakhargupta1
Copy link
Member

prakhargupta1 commented Nov 1, 2022

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

This issue is to improve queries discovery, placement and navigation. The issue is basically about exploring how the queries interface can be made more integral. This was also raised in a user interview.

Problem: Arguably, queries in Toolpad is the most significant module as it connects a page to a connection. Multiple queries are needed to create a simple business app. So, the DX around queries has to be perfect.
Currently, we show queries in the right sidebar and the editing happens in a big modal. Some thoughts on improvement below:

Some of this includes:

  1. Sorting queries Queries in the query explorer should be custom sortable  #799
  2. Better error handling- Warn on queries that look non-idempotent #1171
  3. Show root cause of the error at the UI level #1263
  4. Show cues when the query is running Show a visual response every time a query runs #1377
  5. Move queries to the left: Move queries section to the left #2138
  6. Use panels/pop-overs instead of modals

Examples 🌈

No response

Motivation 🔦

No response

@prakhargupta1 prakhargupta1 added discussion status: waiting for maintainer These issues haven't been looked at yet by a maintainer design: ui Design design: ux Design labels Nov 1, 2022
@prakhargupta1 prakhargupta1 changed the title Revamp queries Revamp queries UI Nov 2, 2022
@prakhargupta1 prakhargupta1 added umbrella For grouping multiple issues to provide a holistic view and removed discussion status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Nov 2, 2022
@prakhargupta1
Copy link
Member Author

  1. In Connections should be global #1065 and Revamp custom components UI #1259 it is proposed to move Connections and Custom components to the home view. This gives us a lot of space in the left panel.
  2. Queries will take high ground now, as all connections will appear inside the query interface (drop down).
  3. An engineer would spend a good amount of time in creating all the queries required to build the app.

Based on the above 3 arguments, I think it makes sense to move queries to the left panel. When clicked on a query, a Notion style side panel coming from left should be a good experience.

@prakhargupta1
Copy link
Member Author

@gerdadesign As discussed in today's call, about queries, we can explore points 4 and 5. of this issue.

@prakhargupta1
Copy link
Member Author

Just came across this scenario:
I am checking the output of the query and wished I was able to see how this information is being shown on the page. A quick glance would have helped, the dialog box obscures the view.

Screenshot 2023-04-12 at 11 43 56 AM

@prakhargupta1 prakhargupta1 added the feature: Queries Making new API requests label Jul 31, 2023
@prakhargupta1 prakhargupta1 added the scope: toolpad-studio Abbreviated to "studio" label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design: ui Design design: ux Design feature: Queries Making new API requests scope: toolpad-studio Abbreviated to "studio" umbrella For grouping multiple issues to provide a holistic view
Projects
None yet
Development

No branches or pull requests

1 participant