Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on queries that look non-idempotent #1171

Open
2 tasks done
Janpot opened this issue Oct 18, 2022 · 0 comments
Open
2 tasks done

Warn on queries that look non-idempotent #1171

Janpot opened this issue Oct 18, 2022 · 0 comments
Labels
feature: Queries Making new API requests new feature New feature or request priority: low To delay as much as possible scope: toolpad-studio Abbreviated to "studio"

Comments

@Janpot
Copy link
Member

Janpot commented Oct 18, 2022

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

When the user is creating a query, and the mode is set to "Fetch at any time". In the following cases:

  • Fetch: user sets method to something other than GET or HEAD
  • SQL: user writes a query other than SELECT
  • ...?

This could potentially be valid (e.g. a server may accept a POST request for data fetching) so we shouldn't downright disallow it, but we may want to warn the user that it looks like they're defining a destructive query and that they probably want to set the mode to "Only fetch on manual action"

Additionally we may do some of the following to enlarge the pit of success

  • In the message, add a button that switches the mode
  • Pull attention to the mode selector in some way
  • Add a confirmation dialog when the user saves the query that explains the query will run automatically and confirms whether it's their intention
  • ...?

Examples 🌈

No response

Motivation 🔦

No response

@Janpot Janpot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer new feature New feature or request priority: low To delay as much as possible feature: Queries Making new API requests labels Oct 18, 2022
@bharatkashyap bharatkashyap changed the title Warn on queries that look non-edempotent Warn on queries that look non-idempotent Oct 18, 2022
@prakhargupta1 prakhargupta1 mentioned this issue Nov 1, 2022
2 tasks
@Janpot Janpot removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 17, 2023
@prakhargupta1 prakhargupta1 added the scope: toolpad-studio Abbreviated to "studio" label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Queries Making new API requests new feature New feature or request priority: low To delay as much as possible scope: toolpad-studio Abbreviated to "studio"
Projects
None yet
Development

No branches or pull requests

2 participants