-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update create-toolpad-app
to match engines
#2094
Comments
I think we can leave this one up to the user, as long as our package has a correct engines field it should be fine.
Sure, we could initialize with https://github.com/github/gitignore/blob/main/Node.gitignore. Do we consider a folder empty if it only has a gitignore? |
What range do the engines field? May I contribute to this issue? |
I meant it's up to the toolpad user to decide the engines range of their project, we don't need to choose it for them. I've updated the issue description. |
OK I check the node version of the package is >=16.1 |
May I ask what the meaning of the DX is? |
We should also addThis is up to the user, as long as we don't generate code that is incompatible with certain node.js versions then the restrictions ofengines
to thepackage.json
file created bycreate-toolpad-app
@mui/toolpad-app
andcreate-toolpad-app
should do their jobs..gitignore
on the root level withnode_modules
inside it so that this step does not have to be manually done when committing the project? @JanpotThe text was updated successfully, but these errors were encountered: