Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create-toolpad-app to match engines #2094

Closed
1 of 3 tasks
bharatkashyap opened this issue May 30, 2023 · 5 comments · Fixed by #2124
Closed
1 of 3 tasks

Update create-toolpad-app to match engines #2094

bharatkashyap opened this issue May 30, 2023 · 5 comments · Fixed by #2124
Assignees
Labels
create-toolpad-app Issues related to the `create-toolpad-app` CLI tool
Milestone

Comments

@bharatkashyap
Copy link
Member

bharatkashyap commented May 30, 2023

  • From Cannot read properties of undefined (reading 'F_OK') #2092 (comment), we should have a node version check before running
  • We should also add engines to the package.json file created by create-toolpad-app This is up to the user, as long as we don't generate code that is incompatible with certain node.js versions then the restrictions of @mui/toolpad-app and create-toolpad-app should do their jobs.
  • Also a .gitignore on the root level with node_modules inside it so that this step does not have to be manually done when committing the project? @Janpot
@bharatkashyap bharatkashyap added the create-toolpad-app Issues related to the `create-toolpad-app` CLI tool label May 30, 2023
@bharatkashyap bharatkashyap self-assigned this May 30, 2023
@Janpot
Copy link
Member

Janpot commented Jun 2, 2023

We should also add engines to the package.json file created by create-toolpad-app

I think we can leave this one up to the user, as long as our package has a correct engines field it should be fine.

Also a .gitignore on the root level with node_modules inside it so that this step does not have to be manually done when committing the project? @Janpot

Sure, we could initialize with https://github.com/github/gitignore/blob/main/Node.gitignore. Do we consider a folder empty if it only has a gitignore?

@JerryWu1234
Copy link
Contributor

I think we can leave this one up to the user, as long as our package has a correct engines field it should be fine.

What range do the engines field? May I contribute to this issue?

@Janpot
Copy link
Member

Janpot commented Jun 2, 2023

I meant it's up to the toolpad user to decide the engines range of their project, we don't need to choose it for them. I've updated the issue description.

@JerryWu1234
Copy link
Contributor

OK I check the node version of the package is >=16.1
I will check the node version greater than or equal 16.1 before it runs.
and we initialize with that link
Please tell me if there is any error message.

@JerryWu1234
Copy link
Contributor

May I ask what the meaning of the DX is?
what's the full name?

@prakhargupta1 prakhargupta1 added this to the beta-critical milestone Jun 5, 2023
@Janpot Janpot modified the milestones: beta-critical, beta-delighter Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-toolpad-app Issues related to the `create-toolpad-app` CLI tool
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants