add ts declaration for package and check node version on initial star… #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 5, 2023 10:39
…t and move the gitnore to rool level
|
I added a unit test for this code. |
added 4 commits
June 5, 2023 11:18
|
Thanks @JerryWu1234 for the contribution! I've added some comments |
bharatkashyap
added
the
create-toolpad-app
Janpot
reviewed
Jun 5, 2023
| @@ -0,0 +1,667 @@ | |||
| declare namespace PackageJsonTypes { | |||
There was a problem hiding this comment.
Looks like this was copied from https://www.npmjs.com/package/type-fest. Shall we just add this as a dependency?
There was a problem hiding this comment.
I had done it to install this library before.
But there is a lot of code we didn't use it.
if we need to get more declarations from this library, we can change to that library.
There was a problem hiding this comment.
in spite of it not being important, it will waste our time installing dependency when it’s the first time to contribute.
Janpot
reviewed
Jun 5, 2023
Janpot
reviewed
Jun 5, 2023
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
Janpot
reviewed
Jun 5, 2023
Your welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t and move the gitnore to rool level
fix #2094
three points
3.Move the .gitignore file to the root level, move the code to the create-toolpad-app folder, and remove the redundant code.