Codify lodash usage in eslint #1270
Conversation
|
Your Render PR Server URL is https://toolpad-pr-1270.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cdhrruda4994n7g25l8g. |
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
github-actions
bot
removed
the
PR: out-of-date
| @@ -34,6 +34,8 @@ import { | |||
| JsExpressionAttrValue, | |||
| } from '@mui/toolpad-core'; | |||
| import { createProvidedContext, useAssertedContext } from '@mui/toolpad-utils/react'; | |||
| import { filterKeys, mapProperties, mapValues } from '@mui/toolpad-utils/collections'; | |||
| import { set as setObjectPath } from 'lodash-es'; | |||
There was a problem hiding this comment.
If we plan to eventually completely get rid of lodash we could maybe create utility methods for these operations, which for now would still use lodash but then we would know where to replace it.
Just a possibility, maybe it helps to have the lodash imports less spread out.
There was a problem hiding this comment.
To be honest, I'm not sure we should even have utility functions for this. ideally we improve the algorithm altogether to be not so lodashy. setObjectPath also makes us write type-unsafe code, I don't want to enable that sort of code in our codebase
There was a problem hiding this comment.
Got it, yeah for this specific type of operation maybe just normal Javascript would be possible and be more type-safe.
| @@ -1226,7 +1228,7 @@ function QueryNode({ page, node }: QueryNodeProps) { | |||
| Object.fromEntries(node.params ?? []), | |||
| ); | |||
|
|
|||
| const configBindings = _.pick(node.attributes, USE_DATA_QUERY_CONFIG_KEYS); | |||
| const configBindings = filterKeys(node.attributes, (key) => USE_DATA_QUERY_CONFIG_KEYS.has(key)); | |||
There was a problem hiding this comment.
We could abstract this to our own pick function maybe?
Avoid kitchensink libraries, especially unmaintained ones like
lodash. We write a slightly more verbose, but a universally understood style of javascript.