Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't immediately open duplicated apps #1397

Merged
merged 3 commits into from
Dec 1, 2022
Merged

Don't immediately open duplicated apps #1397

merged 3 commits into from
Dec 1, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Nov 30, 2022

Current implementation leaves the user out of control. They may want to

  • only duplicate, not edit
  • duplicate and edit in the same tab
  • duplicate and edit in a new tab

And we shouldn't make that choice for them

This PR shows a snackbar instead with a link to open the duplicated app. similar to how e.g. figma does duplication

Now the user can

  • ignore the snackbar
  • click open to open in the same tab
  • click Cmd+open to open in a new tab

Additionally:

  • tighten the types to make more ergomic API
  • make sure the app is always defined in the dialogs to ensure closing animations look ok
  • reset the form on dialog open
  • remove some unused props
  • autoselect proposed name in dialog
Screen.Recording.2022-11-30.at.17.54.13.mov

@oliviertassinari oliviertassinari requested a deployment to dont-open-dupl - toolpad-db PR #1397 November 30, 2022 16:21 — with Render Abandoned
@oliviertassinari oliviertassinari temporarily deployed to dont-open-dupl - toolpad PR #1397 November 30, 2022 16:22 — with Render Destroyed
@oliviertassinari oliviertassinari temporarily deployed to dont-open-dupl - toolpad PR #1397 November 30, 2022 17:07 — with Render Destroyed
@bharatkashyap
Copy link
Member

Much better UX!

Only one doubt is about the discoverability of opening the duplicated app in a new tab with Control/Command + Open.

@Janpot Janpot merged commit 6534a3f into master Dec 1, 2022
@Janpot Janpot deleted the dont-open-dupl branch December 1, 2022 13:19
@Janpot
Copy link
Member Author

Janpot commented Dec 1, 2022

Only one doubt is about the discoverability of opening the duplicated app in a new tab with Control/Command + Open.

They can drag and drop the link in the tabbar, or right click and use the menu. I think it's a safe assumption that our users know how to use a browser. And even if they don't know this feature, there's no essential functionality taken away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants