Make sure EditableText updates when underlying string changes #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
requested a deployment
to
fix-editable - toolpad-db PR #1400
Render
Abandoned
oliviertassinari
temporarily deployed
to
fix-editable - toolpad PR #1400
Render
Destroyed
bharatkashyap
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having trouble with this with the connections view, where the name can be updated in the popup on the same page.
This demonstrates the fix on the app view, when renamed outside of the editable text. In the apps case it's a less urgent problem as the renaming happens on another page.
Screen.Recording.2022-12-01.at.12.24.11.mov
Also adding a few cleanups in there