Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #1403

Merged
merged 13 commits into from
Dec 2, 2022
Merged

Update dependencies #1403

merged 13 commits into from
Dec 2, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Dec 1, 2022 •
edited
Loading

Bisect out what works from #1386

  • Isolate @sentry/next. It messes in some way with the next.js config that breaks the build. To be investigated.
  • In my opinion sentry does too much magic with our next.js build, it's not the first time I have to go forensics on them messing with webpack config.
  • We're going to need to figure out dealing with the CSS in monaco-editor
  • chalk can be updated now the scripts are ESM
  • Disabled swc in ts-node. To re-enable when they fix the integration

@oliviertassinari oliviertassinari requested a deployment to defsh - toolpad-db PR #1403 December 1, 2022 20:52 — with Render Abandoned
@oliviertassinari oliviertassinari temporarily deployed to defsh - toolpad PR #1403 December 1, 2022 20:52 — with Render Destroyed
@Janpot Janpot added the core Infrastructure work going on behind the scenes label Dec 1, 2022
@oliviertassinari oliviertassinari temporarily deployed to defsh - toolpad PR #1403 December 1, 2022 20:56 — with Render Destroyed
@oliviertassinari oliviertassinari temporarily deployed to defsh - toolpad PR #1403 December 1, 2022 21:08 — with Render Destroyed
@oliviertassinari oliviertassinari temporarily deployed to defsh - toolpad PR #1403 December 1, 2022 21:36 — with Render Destroyed
@oliviertassinari oliviertassinari temporarily deployed to defsh - toolpad PR #1403 December 1, 2022 21:37 — with Render Destroyed
@oliviertassinari oliviertassinari temporarily deployed to defsh - toolpad PR #1403 December 1, 2022 21:59 — with Render Destroyed
@Janpot Janpot marked this pull request as ready for review December 2, 2022 07:52
apedroferreira
apedroferreira approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

If Sentry is causing too much hassle we can maybe look into implementing it in a more manual way, without using the plugin in next.config.

@Janpot Janpot merged commit 46140bb into master Dec 2, 2022
@Janpot Janpot deleted the defsh branch December 2, 2022 14:48
@Janpot Janpot mentioned this pull request Dec 7, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apedroferreira apedroferreira apedroferreira approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Janpot @apedroferreira @oliviertassinari