-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add latest deployment preview in editor #1423
Conversation
|
UX-wise, the only remark I have is that personally I'd avoid icon buttons unless the icon is very universal (e.g. garbage can) even when there's a tooltip. How would you feel about a split button for this? |
b7a2c21
to
50a4adf
Compare
What would we put in a button as a text so it's clear and short? I thought about text, but what I have in tooltip right now is too long, anything other than that seems too long or not clear enough (unless you got some ideas). Btw, I also fixed |
I had something like this in mind, but maybe @gerdadesign wants to chip in? Screen.Recording.2022-12-07.at.10.37.14.mov |
Oh, I actually had done this revision too, but decided against it thinking that it adds unnecessary click to expand dropdown. Another thing that I didn't like about it is that it holds just one menu item rendering the dropdown somewhat useless for the purpose 🤔 As for using icons that might not be so common - I also don't think that it should be a problem, even looking at figma's toolbar: I couldn't tell what most of those icon buttons do at first glance unless I used it once or twice, after that I'd assume it settles in my memory and I know longer need to read the title and could just use visual clues (icons) |
Co-authored-by: Jan Potoms <2109932+Janpot@users.noreply.github.com> Signed-off-by: Vytautas Butkus <vytautas.butkus@gmail.com>
I think Rocket icon should be easier to understand that it stands for deployment. Also, the primary action of the button is deployment so what Jan shared makes sense to me. Now the secondary action that we want to show is: Open the current deployed app. It has to be around this button as it is again related to deployment. The drop-down icon looks standard UX to me. |
Co-authored-by: Jan Potoms <2109932+Janpot@users.noreply.github.com> Signed-off-by: Vytautas Butkus <vytautas.butkus@gmail.com>
@mui/toolpad please review |
When we have deployed version:
When we don't have deployed version yet: