Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest deployment preview in editor #1423

Merged
merged 11 commits into from
Dec 20, 2022
Merged

Conversation

bytasv
Copy link
Contributor

@bytasv bytasv commented Dec 6, 2022

When we have deployed version:
CleanShot 2022-12-08 at 17 33 19@2x

When we don't have deployed version yet:
image

@bytasv bytasv requested a review from a team December 6, 2022 14:14
@bytasv bytasv self-assigned this Dec 6, 2022
@oliviertassinari oliviertassinari requested a deployment to show-deployed-version-in-editor - toolpad-db PR #1423 December 6, 2022 14:14 — with Render Abandoned
@apedroferreira
Copy link
Member

apedroferreira commented Dec 6, 2022

I think the place where this feature would make the most sense would be a list of deployments where every one of them could be previewed?
It's cool to be able to preview the latest deployment more easily, but maybe not at the expense of losing the rocket icon and having the "deploy" button become a bit more complicated to understand?
Anyway these are just some thoughts, nothing that should be blocking as this works well too!

@Janpot
Copy link
Member

Janpot commented Dec 6, 2022

UX-wise, the only remark I have is that personally I'd avoid icon buttons unless the icon is very universal (e.g. garbage can) even when there's a tooltip. How would you feel about a split button for this?

@bytasv
Copy link
Contributor Author

bytasv commented Dec 6, 2022

How would you feel about a split button for this?

What would we put in a button as a text so it's clear and short? I thought about text, but what I have in tooltip right now is too long, anything other than that seems too long or not clear enough (unless you got some ideas).
Im also thinking that the latest deployed version preview is not as important as a current version preview, hence giving it less visibility/importance via icon shouldn't be as bad (subjective opinion)
I honestly don't know what's the right way to present that as we don't have design, I could change to whatever if you can specify how you see it, or we can ask Gerda for design if needed

Btw, I also fixed findLastRelease - thanks for tip.

@Janpot
Copy link
Member

Janpot commented Dec 7, 2022

I had something like this in mind, but maybe @gerdadesign wants to chip in?

Screen.Recording.2022-12-07.at.10.37.14.mov

@bytasv
Copy link
Contributor Author

bytasv commented Dec 7, 2022

I had something like this in mind, but maybe @gerdadesign wants to chip in?

Oh, I actually had done this revision too, but decided against it thinking that it adds unnecessary click to expand dropdown. Another thing that I didn't like about it is that it holds just one menu item rendering the dropdown somewhat useless for the purpose 🤔
As for using just icon vs menu item as you shown here - IMO icon with tooltip is easy to learn once and makes it one-click away, where with dropdown, you would still have to learn that this function is actually behind this dropdown 🤷

As for using icons that might not be so common - I also don't think that it should be a problem, even looking at figma's toolbar:
image

I couldn't tell what most of those icon buttons do at first glance unless I used it once or twice, after that I'd assume it settles in my memory and I know longer need to read the title and could just use visual clues (icons)

Co-authored-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
Signed-off-by: Vytautas Butkus <vytautas.butkus@gmail.com>
@prakhargupta1
Copy link
Member

I think Rocket icon should be easier to understand that it stands for deployment. Also, the primary action of the button is deployment so what Jan shared makes sense to me.

Now the secondary action that we want to show is: Open the current deployed app. It has to be around this button as it is again related to deployment. The drop-down icon looks standard UX to me.

@oliviertassinari oliviertassinari temporarily deployed to show-deployed-version-in-editor - toolpad PR #1423 December 8, 2022 15:34 — with Render Destroyed
@oliviertassinari oliviertassinari temporarily deployed to show-deployed-version-in-editor - toolpad PR #1423 December 9, 2022 08:29 — with Render Destroyed
@oliviertassinari oliviertassinari temporarily deployed to show-deployed-version-in-editor - toolpad PR #1423 December 9, 2022 08:29 — with Render Destroyed
Co-authored-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
Signed-off-by: Vytautas Butkus <vytautas.butkus@gmail.com>
@oliviertassinari oliviertassinari requested a deployment to show-deployed-version-in-editor - toolpad-db PR #1423 December 12, 2022 12:49 — with Render Abandoned
@oliviertassinari oliviertassinari temporarily deployed to show-deployed-version-in-editor - toolpad PR #1423 December 12, 2022 13:03 — with Render Destroyed
@oliviertassinari oliviertassinari temporarily deployed to show-deployed-version-in-editor - toolpad PR #1423 December 12, 2022 13:10 — with Render Destroyed
@bytasv bytasv requested a review from Janpot December 12, 2022 13:10
@oliviertassinari oliviertassinari temporarily deployed to show-deployed-version-in-editor - toolpad PR #1423 December 13, 2022 11:57 — with Render Destroyed
@bytasv bytasv requested a review from Janpot December 13, 2022 12:02
@bytasv
Copy link
Contributor Author

bytasv commented Dec 20, 2022

@mui/toolpad please review

@bytasv bytasv merged commit 88fd671 into master Dec 20, 2022
@bytasv bytasv deleted the show-deployed-version-in-editor branch December 20, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow viewing the current deployment from Edit mode.
5 participants