Simplify RPC logs #1473
Merged
Simplify RPC logs #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
requested a deployment
to
logger - toolpad-db PR #1473
Render
Abandoned
oliviertassinari
temporarily deployed
to
logger - toolpad PR #1473
Render
Destroyed
apedroferreira
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
This is definitely an improvement - I was trying to log the error from the response body before I think, but then the stack wasn't working with JSON.
Also getting the response body in Next.js doesn't seem very straightforward, I hadn't found any alternative to that complicated part with the chunks...
|
|
||
| type LogPayload = ReqResLogPayload | RpcReqResLogPayload; | ||
|
|
||
| function logMethod(method: 'info' | 'trace' | 'error' | 'warn' | 'fatal') { |
There was a problem hiding this comment.
nice, this works better than a function just for logInfo
There was a problem hiding this comment.
Yes, I'm thinking roughly:
fatal: Unrecoverable errors, the node process should crash (or has crashed and this is the report).error: Unexpected, but we can degrade in a safe way. The user experience is impacted, so this must be investigatedwarn: Unexpected, but we can degrade in a safe way. The user experience isn't really impacted, investigate when lots of these happen.info: informational, we want to see these appear in a log aggregator for metrics
We play with logelevel on different use-cases
- production:
info - local:
warn, info will most likely lead to too many logs
There was a problem hiding this comment.
Sounds great, one of the alerts I set up in Sentry was for frequent warnings too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues like: https://sentry.io/organizations/mui-org/issues/3783806362/?environment=production&project=6763402&query=&referrer=issue-stream&statsPeriod=14d
We're not using JSON to transfer messages in RPC (Though it looks like it 🙂 )