Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin react-router-dom instead of resolutions #1519

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Pin react-router-dom instead of resolutions #1519

merged 2 commits into from
Jan 9, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jan 5, 2023 •
edited
Loading

Fixes yarn install warning with unmet peer dependencies.

Resolutions seem to cause yarn to create slightly different lockfiles between yarn add my-package and yarn install. This avoids it altogether

@oliviertassinari oliviertassinari requested a deployment to pin-react-router - toolpad-db PR #1519 January 5, 2023 14:08 — with Render Abandoned
@Janpot Janpot added the core Infrastructure work going on behind the scenes label Jan 5, 2023
@Janpot Janpot marked this pull request as ready for review January 5, 2023 15:09
@Janpot Janpot enabled auto-merge (squash) January 5, 2023 15:09
@oliviertassinari oliviertassinari temporarily deployed to pin-react-router - toolpad PR #1519 January 6, 2023 16:13 — with Render Destroyed
@Janpot Janpot merged commit 0bc2e20 into master Jan 9, 2023
@Janpot Janpot deleted the pin-react-router branch January 9, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apedroferreira apedroferreira apedroferreira approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Janpot @apedroferreira @oliviertassinari