Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a
useNonNullableContext
function to replacecreateProvidedContext
down the line. The problem withcreateProvidedContext
is that it makes it impossible for the react eslint rules to detect stable/unstable context values. In this PR I'm replacing some instances ofcreateProvidedContext
with this new hook and fixing the associate eslint issuesI'm also reordering a bit the utility imports from
@mui/toolpad-core
in anticipation of creating a utils package that we can reuse.@mui/toolpad-core
is intended to share logic between the components and the runtime, we should aim at keeping it lean, utilities meant for broader use can go in new package. For this package we will encourage subpath imports to maximize treeshakeability e.g.I'm not making that switch in this PR, but as a first step, I'm just disallowing importing utilities from
@mui/toolpad-core
.