Fix binding to objects with more than one property

[Janpot]

Currently, adding a binding { a:1, b:2 } breaks the evaluator as it is interpreting this as a code block instead of an expression. This PR fixes the runtime behavior. Also opening #1543 to deal with the editor

[apedroferreira]

This one is testing that even if sx has a broken binding like { the element still shows?

[Janpot]

yes, and that the app doesn't crash

[oliviertassinari]

Using a bisection, I have found this commit breaking the support for:

function run() {
  return "Not found"
}
run()

real use case

function run() {
  if (getRepositoryDetails.data) {
    return `Repository ID: ${getRepositoryDetails.data.id}`
  } else {
    return "Not found"
  }
}
run()

and

const nonProductScopeLabels = ["support: commercial"]

nonProductScopeLabels

real use case

const nonProductScopeLabels = ["support: commercial"]

materialUI.rows
  .concat(muix.rows)
  .filter((issue) => {
    const withoutNonProductScopeLabels = issue.labels.filter(
      (label) => !nonProductScopeLabels.includes(label.name)
    )
    return withoutNonProductScopeLabels.length === 1
  })
  .sort((issueA, issueB) => {
    if (issueA.state === "open") {
      return 1
    }
    if (issueB.state === "open") {
      return 1
    }
    return issueB.number - issueA.number
  })

in the binding. This was reported by Greg because https://master--toolpad.mui.com/_toolpad/app/cl6rqzry10009arlv9sto6qja/pages/ip23ggo throws

(my previous link gets redirected to a wrong URL but this is a different bug)

[Janpot]

🤔 hmm, this was always intended to only support javascript expressions. i.e. anything that can go the the right side of an assigment. Otherwise it gets a bit ambiguous to define which kind of code it accepts exactly. But you should be able to

(() => {
  if (getRepositoryDetails.data) {
    return `Repository ID: ${getRepositoryDetails.data.id}`
  } else {
    return "Not found"
  }
})()

and

(() => {
  const nonProductScopeLabels = ["support: commercial"]

  return materialUI.rows
    .concat(muix.rows)
    .filter((issue) => {
      const withoutNonProductScopeLabels = issue.labels.filter(
        (label) => !nonProductScopeLabels.includes(label.name)
      )
      return withoutNonProductScopeLabels.length === 1
    })
    .sort((issueA, issueB) => {
      if (issueA.state === "open") {
        return 1
      }
      if (issueB.state === "open") {
        return 1
      }
      return issueB.number - issueA.number
    })
})()

Otherwise we need to take it back to the drawing board

[oliviertassinari]

@Janpot Alright, thanks. (() => { I'm using this fix now, we (Greg, for the KPIs page, etc.) need the app to work until we decide what's the right solution (if it's not this one).