Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix templates after dog API changed #1544

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Fix templates after dog API changed #1544

merged 1 commit into from
Jan 11, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jan 11, 2023

There seems to be a change in the dog api for subbreeds.

This reveals at least two things:

  1. We could use validation of some sort of binding output to alert users they're trying to bind invalid stuff. And prevent passing invalid values to components to avoid unhelpful error messages. If we encourage users to rely on their types we should prevent incompatible values from arriving in the component
  2. It's not the best to rely on externalities that we don't control

@oliviertassinari oliviertassinari requested a deployment to try-fix-tests - toolpad-db PR #1544 January 11, 2023 14:42 — with Render Abandoned
@oliviertassinari oliviertassinari temporarily deployed to try-fix-tests - toolpad PR #1544 January 11, 2023 14:43 — with Render Destroyed
@Janpot Janpot added test bug 🐛 Something doesn't work labels Jan 11, 2023
@Janpot Janpot marked this pull request as ready for review January 11, 2023 14:56
@Janpot Janpot changed the title Fix tests after dog API change Fix templates after dog API changed Jan 11, 2023
@Janpot Janpot enabled auto-merge (squash) January 11, 2023 14:58
@Janpot Janpot merged commit 16fc487 into master Jan 11, 2023
@Janpot Janpot deleted the try-fix-tests branch January 11, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants