Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize js evaluation across project #1548

Merged
merged 11 commits into from
Jan 13, 2023
Merged

Reorganize js evaluation across project #1548

merged 11 commits into from
Jan 13, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jan 12, 2023 •
edited
Loading

Starting work on getting more debugging information inside of the binding editor. This refactor unifies all Toolpad JS evaluation under a single API that uses a jsRuntime.
There are both a serverJsRuntime based on quickjs and a browserJsRuntime based on eval in an iframe
All code that needs to evaluate something will now explictly have to use one of the runtimes

@oliviertassinari oliviertassinari requested a deployment to eval-reorg - toolpad-db PR #1548 January 12, 2023 11:47 — with Render Abandoned
@oliviertassinari oliviertassinari temporarily deployed to eval-reorg - toolpad PR #1548 January 12, 2023 11:47 — with Render Destroyed
@Janpot Janpot added the core Infrastructure work going on behind the scenes label Jan 12, 2023
@oliviertassinari oliviertassinari temporarily deployed to eval-reorg - toolpad PR #1548 January 12, 2023 11:56 — with Render Destroyed
@Janpot Janpot marked this pull request as ready for review January 12, 2023 13:12
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 12, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 13, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 13, 2023
@oliviertassinari oliviertassinari temporarily deployed to eval-reorg - toolpad PR #1548 January 13, 2023 15:46 — with Render Destroyed
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 13, 2023
@Janpot Janpot enabled auto-merge (squash) January 13, 2023 16:10
@Janpot Janpot disabled auto-merge January 13, 2023 16:10
@Janpot Janpot merged commit d8d82e1 into master Jan 13, 2023
@Janpot Janpot deleted the eval-reorg branch January 13, 2023 16:10
@Janpot Janpot mentioned this pull request Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apedroferreira apedroferreira Awaiting requested review from apedroferreira

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Janpot @oliviertassinari